Problems with a script

Marpe · Sep 27th 2018

Hello

I'm trying to get my head around this new scripting system and it's going okay for now. At least we don't have to twist our brains with RPN anymore, but I actually find the old scripting language easier, maybe because I never did anything like Pascal. I have a problem here, I'm trying to make throttle that would be increased by 1 notch everytime you press the throttle button, but no matter what I do, it'll increase by 2 notches instead of 1 for every click. What am I doing wrong?

Code

procedure Cockpit_OnButton(id: string; value: boolean);
begin
if (id = 'Throttle') then
begin
throttle_mode := throttle_mode_last + 1;
throttle_mode_last := throttle_mode;
end
else if (id = 'Neutral') then
begin
throttle_mode := 0
end
else if (id = 'Brake') then
begin
throttle_mode := throttle_mode_last - 1;
throttle_mode_last := throttle_mode;
end
else if (id = 'RailBrake') then
begin
end
else if (id = 'MaxBrake') or (id ='EmergencyBrake') then
begin
end;
end;

Display More

2nd question:

From the main-file I have this procedure:

Code

procedure OnButton(id: string; value: boolean; cockpitIndex: byte);
begin
Cockpit_OnButton(id, value);
end

But if I then wrote in the cockpit script to send the "id" (Throttle) to a specific procedure for the throttle mode:

Code

procedure Cockpit_OnButton(id: string; value: boolean);
begin
if (id = 'Throttle') then
begin
Cockpit_Throttle_Mode(id);
end;
end;

... I keep getting an unknown identifier error when trying to pack the script!

Marcel Kuhnt · Sep 27th 2018

It's very easy: The OnButton procedure will be called twice: On mouse button down and on mouse button up - you have to check "value", wether it was pressed (true) or released (false).

ACMG · Sep 27th 2018

Quote from Marpe

throttle_mode := throttle_mode_last + 1;
throttle_mode_last := throttle_mode;

Why the extra _last variable, why don't you do this instead:

Code

throttle_mode := throttle_mode + 1;

Or do we even have shorthands like throttle_mode++ and throttle_mode-- in the script language now?

Marcel Kuhnt · Sep 27th 2018

Quote from ACMG

shorthands like throttle_mode++ and throttle_mode--

No, that's not implemented, because it is not Pascal conform.

The "original" Pascal has inc(x) and dec(x), but I did not tested it in our "Script Pascal"...

Marpe · Sep 27th 2018

It did the trick, thanks!

ACMG, I just tried many things, couldn't understand why it added 2 but there was a good explanation ..